rattail-project/rattail Changeset

Changeset - afada0171a31

Parent rev.

Child rev.

[Not reviewed]

0 1 0

Lance Edgar - 10 years ago 2015-02-07 12:41:15
ledgar@sacfoodcoop.com

Add encoding support to `files.count_lines()`.

This seemed to be necessary when working with a file with 'latin_1'
encoding. Hopefully this is a good change and doesn't break anything..?

1 file changed with 7 insertions and 5 deletions:

rattail/files.py

0 comments (0 inline, 0 general)

rattail/files.py

➞

Show inline comments

 from __future__ import unicode_literals
 import io
 import os
 import os.path
 import shutil
@@ @@ -38,7 +39,7 @@ from datetime import datetime @@
 import pkg_resources
 def count_lines(path):
+def count_lines(path, encoding=None):
     """
     Counts the number of lines in a text file.  Some attempt is made to ensure
     cross-platform compatibility.
@@ @@ -46,13 +47,14 @@ def count_lines(path): @@
     :param path: Path to the file.
     :type path: string
     :param encoding: Optional encoding to be used when opening the file for
       reading.  This is passed directly to :func:`python:io.open()`.
     :returns: Number of lines in the file.
     :rtype: integer
     """
     f = open(path, 'rb')
     lines = f.read().count('\n') + 1
     f.close()
     with io.open(path, 'rt', encoding=encoding) as f:
         lines = f.read().count('\n')
     return lines

0 comments (0 inline, 0 general)